For some odd reason, when I use the toon shader (used with my own (very simple) material code, copied from the templates directory), The outline changes color depending on the angle of the camera and model.

I'm really no good at (writing) shaders (at least not yet), so could one of you gurus out there help me fix this problem?

(I'm thinking maybe it has something to do with that little bit of asm at the end that does the outline, but I have no idea which parameter changes the color of the outline.)

Maybe posting the asm snippet would be handy so that users who know asm can guide you in the correct direction But I think you can solve the problem by making the outline dependant to a view like in a Blinn-Phong effect.

Cheers

Frazzle

OK, Check:

Code:

---

technique toon
{
	pass one
	{		
		VertexShader = compile vs_1_1 toonVS();
		PixelShader = compile ps_1_4 toonPS();
	}
	pass two 
	{
		CULLMODE=CW;
		vertexShaderConstant[0] = <matWorldViewProj>;
		vertexShaderConstant[16] = <10/20.>;
		
		VertexShader =	asm
		{
			vs_1_0
			dcl_position v0
			dcl_normal v3
			dcl_texcoord v7
			mov r0,v0
			mul r1,c16.x,v3
// Scale the normal
			add r0.xyz,r0.xyz,r1.xyz
			m4x4 oPos,r0,c0
// Transorm position to clip space
			mov oD0, c0
			mov r0,c0
		};
	}
}

---

That's the whole technique, in case the problem may be more than just the asm.

maybe you'll give hlsl a chance?

here you'll find my ready2use toon shader
http://www.earthcontrol.de/main.php?loc=...p;aktion=listit

and in this thread you'll find the solution to use only the outline:
http://www.coniserver.net/ubbthreads/showflat.php/Cat/0/Number/813095/Main/811388/#Post813095

That's exactly the reason why HLSL was developed, to make code reuse look more structured and readable
Try ello's suggestions since HLSL is more flexible than asm IMHO

Cheers

Frazzle

@ello:

Thanks! One thing, though. Your shader works, but I'm not getting any rough shading fx, like you show in the screenshot on your website. Maybe I could fix this by doing something with the PS_OUTPUT function?

Actually, nvr mind. I improvised: I used the outline_vs and ps functions from your shader, and then copied and pasted them into the other shader code.

(please excuse the bump, my edit time ran out)