Zorro keeps crashing when I try to run this script and I have no idea why. I think the script is ok but any ideas would be appreciated:

I wanted to thank the responders to my HMA script. I am still trying to get it to work but hopefully we can get a copy of it into the indicators.c for the next version.


function run()
{
var *ClosePrice = series(priceClose());
var *EMA17 = series(EMA(ClosePrice,17));
var *EMA35 = series(EMA(ClosePrice,35));
var *EMABuySignal = series(0);
var *EMASellSignal = series(0);
var *RSIBuySignal= series(0);
var *RSISellSignal= series(0);



if(EMA17 > EMA35)
EMABuySignal=1;
else
EMABuySignal=0;

if(EMA17 < EMA35)
EMASellSignal=1;
else
EMASellSignal=1;

if(RSI(ClosePrice,16) > 50)
RSIBuySignal=1;
else
RSIBuySignal=0;

if(RSI(ClosePrice,16) < 50)
RSISellSignal=1;
else
RSISellSignal=0;


if((EMABuySignal[0] +RSIBuySignal[0] > 1.5) && (EMABuySignal[1] +RSIBuySignal[1] < 1.5))

enterLong();

if((EMASellSignal[0] +RSISellSignal[0] > 1.5) && (EMASellSignal[1] +RSISellSignal[1] < 1.5))

enterShort();
}

The reason for the crash is because you have alot of coding errors in your script. Ive retyped out your code for you to see where Ive changed it.



Basically Im still not an expert myself but from what I can tell with your script you created a pointer called EMABuySignal then you tried to fill it with an integer. Use the crossOver & crossUnder functions with a delay for checking to see whether EMAs have crossed.

Thanks I had this script before:

function run()
{
var *ClosePrice = series(priceClose());
var *EMA17 = series(EMA(ClosePrice,17));
var *EMA35 = series(EMA(ClosePrice,35));



if((crossUnder(EMA17,EMA35)) and (RSI(ClosePrice,16) < 50))

enterShort();

if(crossOver(EMA17,EMA35) and (RSI(ClosePrice,16) > 50))

{
enterLong();}

}

However, I did not know how to enter a trade if EMA's crossed and then the RSI turned positive after the cross.

You are saying that using the delay it will trigger a buy if RSI turns up after a positive ema cross has occurred in a prior period? What if I wanted to add one more condition and get executions only when all 3 are met? Thanks a lot for your help

Yes exactly you can set the delay longer than 1 bar, so if you changed delay to say 3 for example. The entry conditions would check to see if the EMAs have crossed in the last 3 bars & if they have and the other conditions are met then the trade will enter.

If you then say wanted to add a 3rd condition lets say for example the Stoch has to be above 20 or below 80 also.



Hope this helps, and if Ive advised incorrectly anyone please feel free to correct.

What has happened to NumBarCycles variable?