I cannot figure out why this code doesn't work. It should replace every 's' character with a 'f' character. It manages to replace once then terminates the string directly after.

Example: "This is a test string!" becomes "Thif", when it should be "Thif if a teft ftring!".

Code:

---

char* chstrswithf(char* a)
{
	while(*a != '\0')
	{
		if(*a == 's')
			*a = 'f';
		a++;
	}
	return a;
}

---

People!?

This code looks ok to me, how do you call it?

Well I know how I would ordinarily do it with strings..

Code:

---

string chstrswithf(string a)
{
        int temp_pos = 0;
	while(a[temp_pos] != '\0')
	{
		if(a[temp_pos] == 's')
			a[temp_pos] = 'f';
		a++;
	}
	return a;
}

---

BUT Lite-C doesn't seem to support indexing a string..

It's late though, so I hope you get this figured out.. Perhaps I will look at it again when I get up.

Good luck,

mbartman: Your modification does not make much sense in this context - *a and a[0] are equivalent in C/C++.

Sheefo: Your code is absolutely correct. The reason for the problem is a bug in the lite-C compiler. The line

*a = 'f';

writes an integer into memory, not a char. Therefore the 'f' and three zeros are written, which truncates your string behind the 'f'.

This will be fixed in the next release. Thank you for finding this bug.

Workaround: memset(a,'f',1);

You're right jcl, I shouldn't be coding that late at night, it's dangerous lol

I thought my code was right

The workaround works, so I am happy

Thanks jcl.