I have to take this back, it now crashes with &foo as well - but now I see the reason:

diag_var( "%s", name );

That's the crash. "name" is not a var, its a char* so youre passing a wrong argument type, and "%s" wont work in diag_var anyway I guess.