Trade loop recursion

Posted By: dpn

Trade loop recursion - 04/25/21 17:05

Hello,

I'm trying to test the "grid trading" script from the online manual, on chapter "Tips & Tricks", but its output is "Warning 048 : trade loop recursion";
Someone can help me to find the faulty action?

(Note: ExitTime is no more valid so I changed it in LifeTime)

Thanks

Code

// helper function for finding trades at a grid line
bool findTrade(var Price,var Grid,bool IsShort) 
{
  for(open_trades)
    if((TradeIsShort == IsShort)
      and between(TradeEntryLimit,Price-Grid/2,Price+Grid/2))
        return true;
  return false;
}
  
function run() 
{
  BarPeriod = 1440;
  Hedge = 2; 
  EntryTime = ExitTime = 500;  
  var Price;
  var Grid = 100*PIP; // grid spacing
  var Current = priceClose();
// place pending trades at 5 grid lines  
// above and below the current price
  for(Price = 0; Price < Current+5*Grid; Price += Grid) {
    if(Price < Current-5*Grid)
      continue;
    if(Price < Current and !findTrade(Price,Grid,true))
      enterShort(0,Price,0,Grid);      
    else if(Price > Current and !findTrade(Price,Grid,false))
      enterLong(0,Price,0,Grid);
  }
}

Posted By: AndrewAMD

Re: Trade loop recursion - 04/25/21 18:04

One should never prematurely exit a for(open_trades) loop prematurely without using the break_trades macro. Otherwise, you will see lots of strange side effects that will ruin your trading algorithm.

So basically, the function needs to be re-written. Something like this (untested):

Code

bool findTrade(var Price,var Grid,bool IsShort) 
{
  bool out = false;
  for(open_trades)
    if((TradeIsShort == IsShort)
      and between(TradeEntryLimit,Price-Grid/2,Price+Grid/2)){
        out = true;
        break_trades;
      }
  return out;
}

Posted By: dpn

Re: Trade loop recursion - 04/25/21 19:03

Thank you AndrewAMD for the prompt response;

I've re-tested the script with your suggestions and it runs correctly (Great!!);

thank you very much for the help;

Ciao