2.33 brokerTrades(1);

Used it with MT4 bridge, removed all trades from Zorro.

Did not add the missing ones, but removed all.
Assume I should not have done that, since on the MT4 bridge it does not state it is supported.

Did install latest MT4 bridge, 2.06 vs. 2.09, maybe that is why?

No. Your plugin must support GET_TRADES for this to work correctly.

Bad luck, did check the new MT4 bridge Version, didn't find it, just wanted to be sure.
Although, then besides me being silly, the bug is, that it does anything, although the brigde doesn't support it ---> very dangerous.


Possible solution, if tradestruct holds trades and brokerTrades(1) returns nothing or zero, throw message log.
Hint user to clean his trades if wanted by removing .trd file manually, or implement a force switch.

GET_TRADES returning zero can mean that this command is not supported, but also that no trade is open. You can use that command only when a) the plugin supports it and b) only a single Zorro instance trades with that broker and there is no manual trading. In other words, you must know exactly how and what for you want to use it.

Exactly, so I would suggest if the plugin does not support it, it does nothing. Cause if trade struct contains trades, but even if plugin supports the command but for any reason returns "" or 0, it should not wipe the Trades from the struct.

Reread this:Zorro does not necessarily know whether or not GET_TRADES is supported, but you do. The documentation will tell you whether or not GET_TRADES is supported. No trades detected means all your trades will get replaced with no trades. You should not expect any other behavior.

From a developers point of view, that is totally correct.
Just since it does that without any further possibility do catch it, so even if you develop, and for any reason your API returns nothing, you can't catch that behaviour in your code, cause it just does what it does.

But besides that, it's just a question of perspective, i wonder @JCL do you plan on implementing that feature for MT4/5 bridge?
Cause that is really a nice one.

Okay, then let's talk about the "perspective":If the broker shows that no trades are open, and your intent is to update your Zorro trades to synchronize with that of the broker, then it is only correct to delete all trades on the Zorro-side.

For example, if IB closes all of my positions (due to risk mitigation), I would certainly want my Zorro-side trades to be removed. If the Zorro-side trades were not removed, and I tried to close the trades on the Zorro side, I'd accidentally open a position in the wrong direction!

Yes, you are right.
Thank you for sharing your thoughts about it and once you point it out, I fully agree.

I really would love that feature in MT4 / 5 too, it definitly is a really nice one.

Edit: I can confirm it works