sorry for double posting..... just remembered...

The following code in the first if(movement_mode==0) branch:

IF (z_force < -2) { //are we falling?

vec_set(temp,my.x); //scan in front of player to see if he has hit a wall
temp.x += 30 * cos(my.pan);
temp.y += 30 * sin(my.pan);
temp.z = my.z + player_head_height; //scan at head height
trace_mode = ignore_me+ignore_sprites+ignore_models;
result = trace(my.x,temp);
IF(result == 0) {
ledge_grab_test = 0;
} ELSE {
IF (result > 0) && (ledge_grab_test == 0) {
vec_to_angle(temp,normal.x);
IF (abs(ang(my.pan - (temp.pan - 180))) < 30) {
temp2.pan = (temp.pan - 180); //make player face towards ladder
vec_set(temp,target.x); //scan to see if there is space up above player for it to grab onto ledge
temp.x += 10 * cos(temp2.pan);
temp.y += 10 * sin(temp2.pan);
temp.z += player_head_height - 2; //scan at head height
target.z += 10;
trace_mode = ignore_me+ignore_sprites+ignore_models;
result = trace(temp.x,target.x);
// vec_to_angle(temp,target.x);
IF (result > 0) { //if we have a wall in the way, and the surface above is less than a 10 degree slant
vec_set(temp,my.x); //scan to see if there is space up above player for it to grab onto ledge
temp.z += player_head_height - 2; //scan at head height
trace_mode = ignore_me+ignore_sprites+ignore_models;
result = trace(temp.x,target.x);
IF (result == 0) { //scan above head to make sure we didn't hit a roof
ledge_grab_test = 1;
movement_mode = 10;
my.pan = temp2.pan; //make player face towards ladder
}
}
}
}
}


can be safely replaced by the following with NO problems at all. tested it out myself.... Asu can see, the code is much shorter and easier to execute...

IF (z_force < -2) { //are we falling?

vec_set(temp, my.x);//trace straight from belly
temp.x += 30 * cos(my.pan);
temp.y += 30 * sin(my.pan);
temp.z += 30;
vec_set(temp3, my.x);
temp3.z += 30;
trace_mode = ignore_me+ignore_sprites+ignore_models;
result = trace(temp3, temp);
if(result> 0 && ledge_grab_test == 0)
{
//IF (abs(ang(my.pan - (temp.pan - 180))) < 30)
//{
vec_to_angle(temp,normal.x);
temp2.pan = (temp.pan - 180);
vec_set(temp, my.x);
temp.z += 42;
vec_set(temp3.x, my.x);
temp3.z += 42;
temp3.x += 30 * cos(my.pan);
temp3.y += 30 * sin(my.pan);
trace_mode = ignore_me+ignore_sprites+ignore_models;
result = trace(temp, temp3);
if(result ==0)
{
vec_set(temp,my.x); //scan to see if there is space up above player for it to grab onto ledge
temp.z += 50; //scan at head height
trace_mode = ignore_me+ignore_sprites+ignore_models;
result = trace(temp.x,target.x);
if(result == 0)
{
ledge_grab_test = 1;
movement_mode = 10;
//move_vec.z =0;
my.pan = temp2.pan; //make player face towards ladder
}






}
}

//IF (abs(ang(my.pan - (temp.pan - 180))) < 30)
//}
else
{
ledge_grab_test = 0;
}

}
else
{
ledge_grab_test = 0;
}

Gamespider! Really good cleaning up of the code. It is quite messy and buggy, it was my first attempt at a movement script like that.

The difference between:
if(movement_mode==2) and if (movement_mode==12)

I think I used one for climbing up when you were at the top of a ladder and the other was for climbing up if you had grabbed onto a ledge, as there may have been slightly different behaviour and different code for each if statement.

The (movement_mode == 3), I think I added that to stop the player getting stuck in certain circumstances or just so it can work in with whatever animation may be used. I think it was meant to move the player forward when it nears the top of pulling itself up onto a ledge.

But if you can understand this code, how it is working, and be able to clean it up like that, you are on your way to doing some great stuff. Soon you'll be making code alot better than that 8)

It's here:

Zelda Code Implemented

But I'm not planning on renewing my subscription to that URL when the time comes next month, so that link wont be active for long, if it's still in demand afterwards perhaps I'll upload it elsewhere.

Just to eliminate the pending wave of confusion:

http://www.accessphenomenon.com/zelda.zip

I'll see about re-uploading my original test zip once I sort some stuff out. I don't know why I deleted it...all of the other various tester levels seem to still be there.

It was really nothing. what i did was to trace straight from 30 quant above the player origin. If ithit a wall, the code traces straight from 42 quants above the origin. If it hits nothing, the player grabs the ledge....

therefore it grabs a ledge if there is a wall below a certain point and no wall above it....a characteristic property of a ledge...

@ axys,
I did not say that there was anything wrong with the (movement_mode == 3) branch. It is absolutely necessary tostop the player getting stuck.What i said was that the first set of trace instructions in (movement_mode == 3) branch is unnecessary

However, That still doesnt aanswer my first question.....
1. What about grabbing a ladder from the top???

I'd like to jump in too... it was only mentioned briefly, but what about jumping? Is the jumping pretty good?

My jump will land me on the next block above me if there is one... technically, I could ascend a 10 story bulding from the inside, 1 floor at a time, just by jumping... but then, this was a simple 'lets see what it does' code.. so how is the jumping in the Zelda code?

I'm not too sure about grabbing a ledge from the top, can you walk backwards off a ladder's top and grab it as you fall? Can you jump up to a ladder and grab onto it mid air? I can't remember if I set it up so that you can only use a ladder if you are on the ground or not. As to how you'd get that to work, allow the player to grab onto the ladder even if he is airborne, that might work. I think that the ultimate way to get ladders working the best, is to have trigger areas where if the player enters it, ie walks to the top of a ladder, he automatically climbs onto it, it may be tricky to program.

@BlueBeast
I'd say the jumping is average, not the best, the jumping height changes slightly when the frame rate is low, which is a bit annoying, and you can bob in the ground and stuff when you land, otherwise it works pretty cool, the animations with the jumping are good.

Nope tried out everything..
The player doesnt grab the ladder by walking backwards....

I will try toget it working as soon as possible.