Gamestudio Links
Zorro Links
Newest Posts
Data from CSV not parsed correctly
by EternallyCurious. 04/18/24 10:45
StartWeek not working as it should
by Zheka. 04/18/24 10:11
folder management functions
by VoroneTZ. 04/17/24 06:52
lookback setting performance issue
by 7th_zorro. 04/16/24 03:08
zorro 64bit command line support
by 7th_zorro. 04/15/24 09:36
Zorro FIX plugin - Experimental
by flink. 04/14/24 07:48
Zorro FIX plugin - Experimental
by flink. 04/14/24 07:46
AUM Magazine
Latest Screens
The Bible Game
A psychological thriller game
SHADOW (2014)
DEAD TASTE
Who's Online Now
4 registered members (Quad, AndrewAMD, EternallyCurious, 7th_zorro), 511 guests, and 1 spider.
Key: Admin, Global Mod, Mod
Newest Members
EternallyCurious, 11honza11, ccorrea, sakolin, rajesh7827
19046 Registered Users
Previous Thread
Next Thread
Print Thread
Rate Thread
Custom header function #482752
03/25/21 14:17
03/25/21 14:17
Joined: Aug 2020
Posts: 59
London
Neb Offline OP
Junior Member
Neb  Offline OP
Junior Member

Joined: Aug 2020
Posts: 59
London
Hi,

Needed to create custom header function, which i put in include folder.
However, I am wondering if I can somehow optimise it even more, regarding how I call it.

in run I have:

vars Highs = series(priceHigh());
vars Lows = series(priceLow());
vars Opens = series(priceOpen());
vars Closes = series(priceClose());


Function is returning boolean and signature is like this:

bool Pattern(NumPattShortY,Highs,Lows,Closes,Opens);

Def part looks like this:

bool Pattern(int numeropattern,vars Highs, vars Lows, vars Closes, vars Opens)
{
bool PtnBaseSA;
switch(numeropattern)
{
case 1:
PtnBaseSA = abs(Opens[1]-Closes[1])<0.5*(Highs[1]-Lows[1]);
break;
case 2:
PtnBaseSA = abs(Opens[1]-Closes[5])<0.5*(Highs[5]-Closes[1]);
break;
case 3:
PtnBaseSA = abs(Opens[5]-Closes[1]) <0.5*(MaxVal(Highs,5) - MinVal(Lows,5));
break;

*
*
*
return PtnBaseSA;
}

My question is can I somehow cut this "Highs,Lows,Closes,Opens" in definition and call and change it with something shorter and more efficient (array of series ..?)?
And how then PtnBaseSA would change as well ?
Excuse me for my bad programming knowledge ! frown


Thanks,

Neb

Re: Custom header function [Re: Neb] #482753
03/25/21 16:46
03/25/21 16:46
Joined: Aug 2020
Posts: 59
London
Neb Offline OP
Junior Member
Neb  Offline OP
Junior Member

Joined: Aug 2020
Posts: 59
London
Can I put this:

vars Highs = series(priceHigh());
vars Lows = series(priceLow());
vars Opens = series(priceOpen());
vars Closes = series(priceClose());

In the definition of function:

bool Pattern(NumPattShortY,Highs,Lows,Closes,Opens); ??

like:

bool Pattern(int numeropattern)
{
bool PtnBaseSA;

vars Highs = series(priceHigh());
vars Lows = series(priceLow());
vars Opens = series(priceOpen());
vars Closes = series(priceClose());

switch(numeropattern)
{
case 1:
PtnBaseSA = abs(Opens[1]-Closes[1])<0.5*(Highs[1]-Lows[1]);
break;
case 2:
PtnBaseSA = abs(Opens[1]-Closes[5])<0.5*(Highs[5]-Closes[1]);
break;
case 3:
PtnBaseSA = abs(Opens[5]-Closes[1]) <0.5*(MaxVal(Highs,5) - MinVal(Lows,5));
break;

*
*
*
return PtnBaseSA;
}


Will it work the same way ?

N.

Last edited by Neb; 03/27/21 08:09.
Re: Custom header function [Re: Neb] #482754
03/25/21 16:59
03/25/21 16:59
Joined: Aug 2020
Posts: 59
London
Neb Offline OP
Junior Member
Neb  Offline OP
Junior Member

Joined: Aug 2020
Posts: 59
London
Getting

Error 041: Wrong series usage!

for this idea. Doesn't work ! frown

Anyone ?

Thanks,

Neb

Re: Custom header function [Re: Neb] #482762
03/26/21 03:12
03/26/21 03:12
Joined: Mar 2017
Posts: 21
J
jyd Offline
Newbie
jyd  Offline
Newbie
J

Joined: Mar 2017
Posts: 21
Maybe give it a try using seriesO(), seriesH()... instead? Also you don't have to put these in your method's signature if you only use them internally

Re: Custom header function [Re: Neb] #482770
03/27/21 08:10
03/27/21 08:10
Joined: Aug 2020
Posts: 59
London
Neb Offline OP
Junior Member
Neb  Offline OP
Junior Member

Joined: Aug 2020
Posts: 59
London
Hi,

Sorry I did exclude series from signature, just did not write it correctly here.
Changed original post.
That anyway did not help. frown

Thanks !


Moderated by  Petra 

Powered by UBB.threads™ PHP Forum Software 7.7.1