I'm trying to code a simple trading system:










But am finding it difficult to get right code for finding out the high low range of first hours trading as the system uses this for stop and profit targets and my coding skills are not that great.

So looking to find the range of the first hours trading of hour(UTC) 8 to 9..

How so you do this?

???

Profit target is set from the the range (PIPS between the high and low of first hour trading)

TakeProfit = ???


Stop to be set in opposite of trade direction equal to first hours trading range..

Stop = ???


Also don’t trade if first hour range is higher than 40 points:

???


Would appreciate any help on the above as i'm stuck.

Thanks.

For the high-low range of the first hour of a trading day, you can use the dayHigh and dayLow functions. In that case, set the EndMarket variable to 1030 so that the "market day" ends at 10:30, one hour after its begin.

http://manual.zorro-trader.com/day.htm

Thanks JCL.

I think the below code works for the Stop and TakeProfit, the only thing I am having trouble with is asking Zorro not to trade when the High and Low range exceeds 40*PIP; I'm getting an "illegal indirection" error?

A little puzzle to the users - who can find all mistakes in this code? Solution tomorrow.

The illegal indirections are the *DH and *DL. What are you trying to accomplish?

After that, there's an extra ";" leading to no statement for the if.

Then, you haven't ended the function.

HTH.

Thanks,

I'm trying to accomplish - if the range is higher than 40 Pips then do not trade.


Updated code below which runs but no trades are entered?

Best next step, then, is to add printf's so you can see what various values are and what the code is consequently doing.

HTH.

Some other problems that I noticed:

set(PEEK) - can render your results useless. NEVER set this flag unless you have a reason.

hour(UTC) - makes no sense, you probably mean lhour()?

16.30 - you have 60 minutes bars and hour() returns an integer anyway, so you can't compare with 16.30.

Thanks guys, appreciate you pointing these things out!

When I do not set the PEEK flag, i get "error 045: Negative price offset at bar 1" ?

I know this is due to the following: It goes away when Peek is set.


I have set StartMarket and EndMarket - from 8am-9am.. As that's the first hours trading that this script is based on that the dayHigh and dayLow should work from. i do not want to set dayLow (UTC,1); for instance as this will based on yesterdays low..?

Anyway, I made some more changes to the code, i'd be interested to see how incorrect this is. I know it will be, but all this help me and any other learners to get to grips with the code.

Edit: i just noticed another error, I'm not sure what this error means exactly?

"Error in 'line 26:
Syntax error: Can't go to FALSEGOTO:DOUBLE::.
< if (Close) >

Thanks for your patience and for pointing out any inaccuracies.

PEEK means that your system is peeking into the future. This in turn means that you will need a time machine for trading it. Therefore setting the PEEK flag is a bad idea if you don't have such a machine at hand.

Better find out the reason of the error 45, and fix it. In your case it's calling dayHigh/Low before the market day is over. You cannot know the high of a day already in the morning. Thus do not call those functions until the EndMarket hour is over.

The syntax error is a wrong condition in the if clause. "If" checks if something is true or false. A var has a floating point value and cannot be true or false. For doing something at a certain time, use the hour or lhour functions.