Gamestudio Links
Zorro Links
Newest Posts
Can't plot daily high & low
by Zheka. 10/14/19 18:39
TWS "Market closed" fix
by jcl. 10/14/19 15:09
2xCapital slider to increase size
by jcl. 10/14/19 14:03
Imgui Lite-c Development
by txesmi. 10/13/19 09:40
A9
by Dooley. 10/11/19 18:53
Need Help Finding Cause of Crash
by Dooley. 10/11/19 18:51
What algorithm is used for BALANCED?
by JamesHH. 10/11/19 17:32
AUM Magazine
Latest Screens
The Space Between
Pogostuck: Rage With Your Friends
Worst Case Z
AckCon'18 - Lotter vs the World 2 - Preview Release
Who's Online Now
7 registered members (exile, Dooley, Dalla, kvm, sdh309795gaas, jibanes, Zheka), 661 guests, and 6 spiders.
Key: Admin, Global Mod, Mod
Newest Members
FrankW, TedMar, raimucuk, vivaldi2, filip
18304 Registered Users
Previous Thread
Next Thread
Print Thread
Rate Thread
Bug in MT4->MT5 adapter #478326
10/03/19 13:44
10/03/19 13:44
Joined: Jul 2017
Posts: 407
Z
Zheka Online OP
Senior Member
Zheka  Online OP
Senior Member
Z

Joined: Jul 2017
Posts: 407
There is a bug in zmq4.mqh in overloading MQL5 functions for the existing MQL4 code base to work on MT5.
Code
#define DEFINE_TIMESERIE(NAME,FUNC,T)                                                                         \
  class CLASS##NAME                                                                                           \
  {                                                                                                           \
  public:                                                                                                     \
    static T Get(const string Symb,const int TimeFrame,const int iShift)                                      \
    {                                                                                                         \
      T tValue[];                                                                                             \
                                                                                                              \
      return((Copy##FUNC((Symb == NULL) ? _Symbol : Symb, [color:#CC33CC]_Period[/color],  iShift, 1, tValue) > 0) ? tValue[0] : -1); \
    }              
....
}

_Period refers to the timeframe/period on the chart that Zorro EA is applied to.

As a result, CMD_HISTORY calls return bars of the timeframe on the chart, rather than that specified by Zorro (which is PERIOD_M1), and that screws up internal Zorro bar construction\gives erroneous data for the Lookback period in Live.

The corrected line that works:
Code
return((Copy##FUNC((Symb == NULL) ? _Symbol : Symb, [color:#CC33CC]TFMigrate(TimeFrame)[/color], iShift, 1, tValue) > 0) ? tValue[0] : -1); 

Re: Bug in MT4->MT5 adapter [Re: Zheka] #478335
10/05/19 08:00
10/05/19 08:00
Joined: Jul 2000
Posts: 27,029
Frankfurt
jcl Offline

Chief Engineer
jcl  Offline

Chief Engineer

Joined: Jul 2000
Posts: 27,029
Frankfurt
Thanks for the info! This will be fixed in the next update.


Moderated by  jcl, Nems, Spirit, Tobias 

Gamestudio download | chip programmers | Zorro platform | shop | Data Protection Policy

oP group Germany GmbH | Birkenstr. 25-27 | 63549 Ronneburg / Germany | info (at) opgroup.de

Powered by UBB.threads™ PHP Forum Software 7.7.1