Hello,

Some days ago I mentioned that BrokerTrade function could not handle the partial closing of trades done manually, well actually it does not handle it from Zorro too.

Let's take the case when the partial closing of a given trade is pending, then BrokerSell2 function will return a trade ID number only and BrokerTrade will have to check this pending order status.

However, as soon as the value returned by BrokerTrade is negative, Zorro will consider the opened position fully closed.

So far, from what I see BrokerTrade can handle trades fully closed and opened trades updates only.

It would be great to fix this issue in the future release.

Also, I noticed that when partially closing a trade through BrokerSell2, even if we affect a value to pProfit, Zorro will replace it by its own estimation which is wrong in that case. It lseems the real value is being divided by the trade number of lots before being reduced. For instance when calling BrokerSell2 to close 1 lot out of 3, the profit value estimated by Zorro will be the correct value divided by 3, for closing 1 out of 2 it will be divided by 2.

BrokerTrade supports partially closing, at least with all plugins that I know. Otherwise all the Z systems and virtual hedging would not work because they all use partial closing. The current profit of an open trade must be returned with BrokerTrade. Otherwise Zorro calculates it from the current price.

Partial closing works but from what I see no thanks to BrokerTrade but to BrokerSell2.
First, BrokerSells has to return the ID of the main trade so BrokerTrade cannot check the status of the trade opened to reduce it as it cannot know its ID.
Second, as soon as BrokerTrade returns a negative number, Zorro considers the trade fully closed even if this number was smaller than the opened position in absolute value.

Also, let's take the case when an order to close or reduce a position is pending, I understand in that case we got no other choice than to return 0 from BrokerSell2 and Zorro will try again x number of times. I think what should rather be done is for Zorro to understand the trade is pending and check through BrokerTrade its status to know whether it has been accepted or not. I do not see such behavior possible with the current architecture.

Moreover, I do not see how BrokerSell2 can handle limit/stop orders because as soon as this method returns a non zero value, Zorro will consider the position as reduced or closed.
I tried to make Zorro understand the order was not filled yet setting dFill value to 0 but it did not work and anyway BrokerSell2 is supposed to return the ID of the main trade only hence I do not see how BrokerTrade could check the status of such pending limit/stop order.

I managed to make limit/stop orders work with BrokerBuy2 by not setting dFill value and later on by returning 0 from BrokerTrade when the order is till pending, however I did have to adjust some stuff to get pml=0 when deleting such an order as Zorro still consider the position as opened.
I do believe that Zorro broker API cannot handle properly limit/stop order to open or reduce a position when the broker allows such orders.

You can contact Support when you have difficulties with a broker plugin implementation. Plugin support is free. BTW, a negative number by BrokerTrade after partial closing is certainly wrong, since that means always a fully closed trade. And your plugin must also handle trade ID changes. Otherwise partial closing would not work with your plugin.

Indeed I read in the BrokerTrade doc: "or the negative number of filled contracts when the trade was closed", my bad I missed that, thanks for the info I will contact them.