Implementing my first strategy in Zorro - from Dick Stoken's book "Survival of the fittest for investors"

I will be glad to hear feedback on any suggestions for improvements.

Main repo - https://github.com/alun/stoken-aca

Older version - https://gist.github.com/alun/4424cb0e61a4955355ea82bb72286af3

I had strategy in Python before - https://katlex.com/stoken/

Currently results are quite different (even with Reinvest = true) - I keep working to make both implementations as close as possible.

Nice clean code.
Your asset mix looks like Ray Dalio's all weather portfolio.
All your trade stats look great, except for the sharpe ratio. I wonder why that is.

Thanks for the feedback, Grant!

yes it's so different to why I found in Python (Sharpe ratio 1.07)

I thought that maybe due to my Zorro test does not reinvest-profits, but with reinvesting it's even less in Zorro - 0.54%

I think there might be differences in how Zorro calculates it.

I see that you use 'Capital' or '(Capital + Profit)' for your position sizing. This means that your position size is always based on your initial capital + your profit, but not a loss(!).
Do you have a particular reason for this?

I always use 'Balance' for position sizing, which is 'Capital + Wintotal - LossTotal' (see https://zorro-project.com/manual/en/balance.htm)

Always log variables for verification when in doubt about certain calculations, esp before switching to live trading. I believe that's the best way to keep bugs away.

I think it's similar:

ProfitTotal - Realized and unrealized total profit so far; WinTotal-LossTotal+WinValTotal-LossValTotal.

So it's PnL of all realised and unrealised trades.

https://zorro-project.com/manual/en/winloss.htm

I understand, but personally I would never calculate a position size based on an unrealised profit or loss, as this can work against you.

Worst case scenario: open position X very profitable > take a large position in Y > open position X ends with a big loss.

I do this all the time in my stock portfolio rotation system. Positions are regularly adjusted from very long to slightly long to flat, and so on.

Yeah I believe stock/ETF rotation (especially with no leverage) are quite different from futures/CFD/forex strategies in the sense of how you look at the realised and unrealised profits.

Here I need to look at cost of my overall portfolio - what I don't have yet is when I rotate one component between risk-on/risk-off, I need to rebalance the two other components so they take 33% of the portfolio each.

I plan to add in next versions.

True, esp with a leveraged portfolio open positions can fluctuate a lot. On the flip side, your strategy is low-frequency, so over time they can fluctuate a lot. To mitigate this you need to rebalance your portfolio indeed, esp in volatile markets. It will a tradeoff between rebalancing your portfolio/risk and limiting your costs.
Maybe a spreadsheet with past trades, powered by a solver could help to find an optimal rebalance frequency?

I think transactional costs are miserable here.

I have modelled the strategy in Python since 2004 started from $10k initial deposit with reinvesting dividends and rebalance on each event of one of the components rotation.

The overall fee was 394.42 for 17+ years. 19721 ETF stocks traded. My broker has 0.02$ per stock per side.